Typescript GitHub action #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjusts types because strictness has been increased
danthedaniel
commented
Dec 16, 2024
| 'use strict'; | ||
|
|
||
| // https://github.com/PrismarineJS/minecraft-data 1.21.1 | ||
| /** @type {Record<string, string>} */ |
Collaborator
Author
There was a problem hiding this comment.
Keeps TypeScript from being overly strict with indexing this hash map.
This doesn't matter much as we're not transpiling. Just seemed right.
Owner
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have ensured this works as expected in a PR against my own
mainbranch.Adds a few new files:
.github/workflows/typecheck.yml- a new action workflow for runningtsctsconfig.json- used bytscso we don't go insane if there are differences between default local config and actions configpackage.jsonandpackage-lock.json- used bynpmto specify which version of TypeScript the project uses